Hello, I’m new to this forum and new to calisthenics. Your workouts are pretty cool, so I try to make own workout routine. My goals are to become better at the basics (pull ups, push ups, dips) and gain muscles.

So here is my workout routine:

Day 1: 

Pistols 3 Sets 10 Reps each Leg

Pull Ups as many Sets as I need to get 25 Reps 
(e.g. Set1: 10 Reps, Set2: 6 Reps, Set3: 5 Reps, Set4: 4 Reps)

HSPU Progressions (Feet on a Chair) 4 Sets Max. Reps

Sit Ups 3 Sets Max Reps

Push Ups 3 Sets Max Reps 


Day 2:
Rest


Day 3:

Jumping Squats 3 Sets Max Reps

HSPU Progressions (Feet on a Chair) 4 Sets Max. Reps

Chin Ups as many Sets as I need to get 25 Reps 

Diamond Push Ups 3 Sets max Reps

Sit Ups 3 Sets max Reps


Day 4:
Rest
 
Day 5:
Same as Day 1


Day 6 & 7:
Rest
 
Do you think this is a good routine?

yeap, this is gonna work provided with good nutrition.

Do you think 30 seconds rest between sets and 90 seconds rest between exercises is enough?

Do you think its better to do the workout as a circle training?

Give 60 - 90 sec rest between exercises and try to seperate the muscle groups in different days. Try it as circle but i think u might have problem in muscle recovery no sure.